Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opbnb chain event contract address case issue #4617

Closed
lonelyIslanders opened this issue Feb 21, 2024 · 3 comments
Closed

Opbnb chain event contract address case issue #4617

lonelyIslanders opened this issue Feb 21, 2024 · 3 comments
Assignees

Comments

@lonelyIslanders
Copy link

Ethers Version

6.8.1

Search Terms

No response

Describe the Problem

The USDT contracts listed on opBNBScan are inconsistent with the results of log.address. In fact, the upper and lower cases are different. Although the codes can be converted into upper and lower cases and compared, it will be very confusing when encountering them for the first time. (BSC chain and ETH are normal, other chains have not been tested yet)ooking for this bug.....
(BSC and ETH chain is normal, other chains have not been tested yet)
image
image

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response

@lonelyIslanders lonelyIslanders added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels Feb 21, 2024
@ricmoo
Copy link
Member

ricmoo commented Feb 22, 2024

Ethers uses the EIP-55 standard for computing the checksum.

I recall there was a CAIP standard that attempted to mix the Chain ID into the checksum, but I thought it was more or less defeated as a bad idea, since it would break the entire ecosystem in non-backwards compatible ways. Could it be that chain is using that checksum method?

I’m unfamiliar with opBNB. Is it related to Optimism or Binance? If you have any contact with them, I’d be curious to find out more and hopefully resolve the checksum earlier than later…

@ricmoo
Copy link
Member

ricmoo commented Feb 22, 2024

Oh! I take much of that back. It simply looks like the example you posted does not include a checksum at all?

The explorer should be updated to use EIP-55 checksums, which should be a simple change for them to make. Same thing, if you have a contact I can reach out the them and if the source is open, can submit a PR. :)

In general, I always recommend addresses be converted to checksum addresses; using ethers getAddress the checksum is simultaneously verified to ensure there were no issues during cut and paste, or otherwise copyin the address.

@ricmoo
Copy link
Member

ricmoo commented Feb 22, 2024

(moving to discussion)

@ricmoo ricmoo removed investigate Under investigation and may be a bug. v6 Issues regarding v6 labels Feb 22, 2024
@ethers-io ethers-io locked and limited conversation to collaborators Feb 22, 2024
@ricmoo ricmoo converted this issue into discussion #4618 Feb 22, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants