Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockTag not being included on estimateGas calls #4610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theforager
Copy link

Currently, the blockTag option for estimateGas is in the documentation and part of the Ethereum RPC spec, but it doesn't currently work in ethers. The option is defined on the input type TransactionRequest, but it's silently ignored in the processing code.

This fixes (or adds) this feature to enable blockTags on estimateGas. It uses it in the same manner and functions that call and other commands do, so it accepts the usual options (like pending, latest, a specific block numbers, etc.).

I think this covers the relevant code sections from my searching, but let me know if there's other fixes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant