Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712 signTypedData does not follow spec #4608

Closed
xrchz opened this issue Feb 17, 2024 · 1 comment
Closed

EIP-712 signTypedData does not follow spec #4608

xrchz opened this issue Feb 17, 2024 · 1 comment
Assignees
@ricmoo
Labels
investigate Under investigation and may be a bug. v6 Issues regarding v6

Comments

@xrchz
Copy link

xrchz commented Feb 17, 2024

Ethers Version

6.11.0

Search Terms

EIP-712 signTypedData eip712

Describe the Problem

According to the spec https://eips.ethereum.org/EIPS/eip-712#definition-of-hashstruct hashStruct should include the encoded type in the data that it hashes. However, the implementation in ethers https://github.com/ethers-io/ethers.js/blob/main/src.ts/hash/typed-data.ts#L420 does not include the type and only hashes the data.

This could also be why #4607 is failing.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response
@xrchz xrchz added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels Feb 17, 2024
@xrchz
Copy link
Author

xrchz commented Feb 17, 2024

Actually maybe this does happen here https://github.com/ethers-io/ethers.js/blob/main/src.ts/hash/typed-data.ts#L385

@xrchz xrchz closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
investigate Under investigation and may be a bug. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xrchz @ricmoo