Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport adraffy/ens-normalize@1.10.1 to ethers@5 #4577

Open
wants to merge 1 commit into
base: v5.7
Choose a base branch
from

Conversation

adraffy
Copy link

@adraffy adraffy commented Feb 4, 2024

  • Replaced ens-normalize/ directory with almost 1:1 port w/types
    • replaced Set with {[x]: x} and membership with set[x] or x in set
    • replaced Map with {}
    • replaced class Emoji with extra wrapper
  • validate.ts runs ens_normalize() through tests.json → no errors

  • Simplified ens-normalize()-related calls in namehash.ts, functionality unchanged
  • Added max argument to dnsEncode()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant