New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old Kovan Network Displayed for ChainId 42 #4531

Open

YamenMerhi opened this issue Jan 5, 2024 · 0 comments

Labels

YamenMerhi commented Jan 5, 2024 •

edited

Suggestion

While working with ethers v6, given chainId 42 it's returning Kovan.
Kovan is now deprecated, and LUKSO Mainnet uses chainId 42. More info here: https://docs.lukso.tech/networks/mainnet/parameters

Keeping it this way will return inaccurate information to developers/users. (Example in a dApp ⬇️ )

ethers.js/src.ts/providers/network.ts

Line 389 in 6017d3d

registerEth("kovan", 42, { ensNetwork: 42 });

I am happy to do the PR, if the change is approved.

YamenMerhi added the documentation label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment