Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout param to ContractTransactionResponse#wait #4497

Conversation

TylerEther
Copy link

From the function documentation, it appears that ContractTransactionResponse#wait was meant to include support for a timeout, but the parameter is missing.

This PR adds the optional timeout parameter to the function.

@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. v6 Issues regarding v6 next-patch Issues scheduled for the next arch release. labels Feb 2, 2024
@ricmoo
Copy link
Member

ricmoo commented Feb 9, 2024

This has been merged into v6.11.0.

Thanks! :)

@ricmoo ricmoo closed this Feb 9, 2024
@TylerEther
Copy link
Author

This has been merged into v6.11.0.

Thanks! :)

Thanks ser!

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants