Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4029
This PR fixes typings of the
parseLog
function. Specifically,parseLog
doesn't work with theLog
s that you receive from variousethers
methods (logs in transaction receipts, when doing aneth_getLogs
, etc.).The typing issue is fairly straight forward, the
parseLog
function expects topics to be astring[]
, but theLog.topics
field is areadonly string[]
. This causes some annoying TypeScript compile issues:Fortunately,
parseLog
doesn't needtopics
to be mutable, so the fix is fairly straight-forward.